Experiment - revert envoy update to attempt to fix integration tests#619
Experiment - revert envoy update to attempt to fix integration tests#619dubious90 wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Pull latest into my fork
Signed-off-by: Nathan Perry <nbperry@google.com>
|
Hmm. is the tracking of https cipher usage broke (again)? |
|
If my hunch is correct (which might very well be not!) the upstream changes that broke us are in these lines: |
Tbh I haven't fully investigated yet. The Docker failure threw a small wrench in my investigation efforts. But the failures started shortly after I merged in the latest envoy update, so it was my first suspect. Agree that it's weird that the CI didn't catch the problem. Let's see how the system operates after we merge in the docker fix |
|
Are we planning to merge this PR, or is it just an experiment to execute the CI? Asking, because merging it would prevent the next Envoy update that is already in review: If it is just an experiment, we could mark it as draft or say something like "DO NOT MERGE" in the PR description. |
|
Fyi, this is what fixed the last docker issue, this one looks related: |
|
Sorry, reading emails in sequence - now I saw that we already merged a fix. Assuming we will be discarding this PR, however if merging it is necessary - let's discuss our options first. |
Integration tests failing on main branch. Seeing if reverting the latest envoy update is the root cause.